[
https://issues.apache.org/jira/browse/BOOKKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580304#comment-14580304
]
Rakesh R commented on BOOKKEEPER-855:
-------------------------------------
Thanks [~hustlmsp] for the contribution.
Could you please point me to the bookkeeper repository, am referring to [apache
bookkeeper
repo|https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java]
I think the patch is not generated out of this and is not properly applying to
me. For example, I couldn't see the below logic in this repo.
{code}
.operationRetryPolicy(new
BoundExponentialBackoffRetryPolicy(conf.getZkTimeout(),
conf.getZkTimeout(), Integer.MAX_VALUE))
{code}
Just few comments based on the attached patch. Probably will do more reviews
once I get the actual repo.
# After looking at the patch, it handles the expiry case of Bookie server. In
that case, please remove the {{& bookie watcher}} part from jira description.
# Please shutdown the {{stateService}} executor in Bookie#shutdown.
# Please make the {{stateService}} executor threads as daemon by giving the
{{new DaemonThreadFactory()}}
# Before re-register operation, its good to add a log saying:
{code}
"ZK client connection expired and scheduling a re-register operation. It may
take few seconds!"
{code}
# In BookieZKExpireTest, instead of sleeping {{Thread.sleep(3000);}}, can we
think of sliced sleeping 500millis and do retries couple of time to see bk
server is running?
> handle session expire event in bookie
> -------------------------------------
>
> Key: BOOKKEEPER-855
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-855
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.4.0
>
> Attachments: BOOKKEEPER-855.patch
>
>
> handling zookeeper session expire event in bookie server & bookie watcher.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
