> On July 9, 2015, 10:29 p.m., fpj wrote: > > Thanks, Sijie, I don't have further comments here.
could you give me +1 on that jira? - Sijie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36296/#review91231 ----------------------------------------------------------- On July 9, 2015, 5:19 a.m., Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36296/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 5:19 a.m.) > > > Review request for bookkeeper and fpj. > > > Bugs: BOOKKEEPER-796 > https://issues.apache.org/jira/browse/BOOKKEEPER-796 > > > Repository: bookkeeper-git > > > Description > ------- > > change ZooKeeperClient to use builder and add stats support > change zookeeper in bookkeeper to use ZooKeeperClient. > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > 3078ff1 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java > 48a76fb > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java > f6ec59c > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java > 49d8e59 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java > fbca7d2 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java > 4e6e3fb > > bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java > dd08f71 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java > 0937bb5 > bookkeeper-server/src/main/java/org/apache/bookkeeper/util/MathUtils.java > 4cff2bb > bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java > 9608240 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ExponentialBackoffRetryPolicy.java > dab7aa7 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java > a479a36 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperWatcherBase.java > 707b842 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooWorker.java > 871612e > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java > 8da9eb4 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperClientZKSessionExpiry.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java > 8fd40c9 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorBookieTest.java > b8020c6 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorPeriodicBookieCheckTest.java > 91aae77 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorPeriodicCheckTest.java > a44eff3 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestLedgerUnderreplicationManager.java > ff1bb0f > > bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestReplicationWorker.java > d47e4b1 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java > 769abbc > > bookkeeper-server/src/test/java/org/apache/bookkeeper/zookeeper/TestZooKeeperClient.java > f48fe37 > > Diff: https://reviews.apache.org/r/36296/diff/ > > > Testing > ------- > > > Thanks, > > Sijie Guo > >
