[ https://issues.apache.org/jira/browse/BOOKKEEPER-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679295#comment-14679295 ]
Hadoop QA commented on BOOKKEEPER-863: -------------------------------------- Testing JIRA BOOKKEEPER-863 Patch [bookkeeper-863.patch|https://issues.apache.org/jira/secure/attachment/12749481/bookkeeper-863.patch] downloaded at Sun Aug 9 18:47:16 UTC 2015 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 120 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} . Tests run: 875 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/951/ > Potential resource leak with unclosed LedgerManager in BookieShell > ------------------------------------------------------------------ > > Key: BOOKKEEPER-863 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-863 > Project: Bookkeeper > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: bookkeeper-863.patch > > > There're more than one occurrence. > Here is an example in ListLedgersCmd#runCmd(): > {code} > LedgerManagerFactory mFactory = > LedgerManagerFactory.newLedgerManagerFactory(bkConf, zk); > LedgerManager m = mFactory.newLedgerManager(); > {code} > m is not closed upon leaving the method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)