[
https://issues.apache.org/jira/browse/BOOKKEEPER-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692782#comment-14692782
]
Sijie Guo commented on BOOKKEEPER-861:
--------------------------------------
[~fpj]
two comments:
{code}
+ if(operationRetryPolicy == null) {
+ logger.error("Retry policy is null");
+ }
{code}
could you remove the logging from exists call? I think it would be annoying and
redundant.
{code}
- if (((null != client && isRecoverableException(e)) || null ==
client) &&
- retryPolicy.allowRetry(attempts, elapsedTime)) {
+ if ((retryPolicy == null) ||
+ ((null != client && isRecoverableException(e)) ||
null == client) &&
+ retryPolicy.allowRetry(attempts, elapsedTime)) {
{code}
I think the change here is making retry infinitely if no retry policy is
provided. I feel it should skip retry if no retry policy is provided, no?
> TestZooKeeperClient is buggy
> ----------------------------
>
> Key: BOOKKEEPER-861
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-861
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.4.0
>
> Attachments: BOOKKEEPER-861.patch
>
>
> I found a couple of bugs in TestZooKeeperClient which were causing the build
> to fail for me. The two problems I found are related to the the retry logic
> object in ZooKeeperClient. We allow it to be null and because we are not
> setting it properly on the test cases, it was causing an NPE for me. I'll
> submit a patch shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
