[
https://issues.apache.org/jira/browse/BOOKKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745374#comment-14745374
]
Hadoop QA commented on BOOKKEEPER-826:
--------------------------------------
Testing JIRA BOOKKEEPER-826
Patch
[BOOKKEEPER-826.diff|https://issues.apache.org/jira/secure/attachment/12754530/BOOKKEEPER-826.diff]
downloaded at Tue Sep 15 12:05:57 UTC 2015
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
. Tests run: 948
. Tests failed: 1
. Tests errors: 3
. The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/958/
> PendingAddOp is ignoring ack response after meet ack quorum constraint
> -----------------------------------------------------------------------
>
> Key: BOOKKEEPER-826
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-826
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client
> Reporter: Charles X
> Assignee: Jia Zhai
> Attachments: BOOKKEEPER-826.diff, BOOKKEEPER-826.patch
>
>
> PendingAddOp is set to completed when it meets ack quorum.
> {code}
> if (ackSet.addBookieAndCheck(bookieIndex) && !completed) {
> completed = true;
> LOG.debug("Complete (lid:{}, eid:{}).", ledgerId, entryId);
> // when completed an entry, try to send success add callbacks in
> order
> lh.sendAddSuccessCallbacks();
> }
> {code}
> responses are ignored after completed flag is set.
> {code}
> if (completed) {
> // I am already finished, ignore incoming responses.
> // otherwise, we might hit the following error handling logic,
> which might cause bad things.
> return;
> }
> {code}
> It is not a correctness problem, but it would introduce performance issue
> during ensemble change. A callback (could be acknowledge before ensemble
> change) has to be delayed to ensemble change completion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
