[
https://issues.apache.org/jira/browse/BOOKKEEPER-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960171#comment-14960171
]
Sijie Guo commented on BOOKKEEPER-866:
--------------------------------------
the patch looks good to me. the failed test in pre-commit job is irrelative to
this change. so +1
> Fix compile issue when Updating junit to latest release version( 4.12) in the
> test of Bookkeeper-server.
> ---------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-866
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-866
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Jia Zhai
> Assignee: Jia Zhai
> Fix For: 4.4.0
>
> Attachments: BOOKKEEPER-866-2.patch, BOOKKEEPER-866.patch
>
>
> When write test cases for BOOKKEEPER-865, It appears that current version of
> junit could not support some new features well, such as Parameterized test.
> Then we try to update junit to latest release version, but found "
> junit.framework.Assert in junit.framework has been deprecated" .
> So using this new ticket to trace this to make the objective more clear.
> The fix is simple,
> replace
> import junit.framework.Assert;
> to
> import org.junit.Assert;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
