That is more convenient. :) Thanks for this. On Wed, Nov 4, 2015 at 5:36 PM, Sijie Guo <[email protected]> wrote:
> Here is the new jenkins job against PRs : > https://builds.apache.org/job/bookkeeper-master-git-pullrequest/ > > - Sijie > > On Wed, Nov 4, 2015 at 1:16 AM, Flavio Junqueira < > [email protected]> wrote: > > > Very nice, Sijie. Thanks for doing this. One question, have you enabled > > jenkins to run pre-commit jobs from PRs? > > > > -Flavio > > > > > On 04 Nov 2015, at 09:09, Sijie Guo <[email protected]> wrote: > > > > > > Hello folks: > > > > > > I've enabled all the GitHub integration hooks for BookKeeper project. > So > > > starting from now, you could either choose the existing review > > board/patch > > > based workflow or new GitHub pull request based workflow on > contributing > > > changes. > > > > > > We'd like to see how GitHub pull request based workflow works in the > > > community. If it turns out to run well, we will start phase out the > > > existing review board/patch based workflow. > > > > > > I've created a wiki page about "Contributing to BookKeeper" based on > the > > > one from Spark Community. Here is the wiki page: > > > > > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/Contributing+to+BookKeeper > > > . Please check it out and try to use the new GitHub work flow on your > new > > > contributions. > > > > > > And also improved existing 'Coding Style' wiki page to fill up more > > > guidelines: > > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/Coding+Guide > > > > > > Let me know if you have any questions. > > > > > > - Sijie > > > > >
