[
https://issues.apache.org/jira/browse/BOOKKEEPER-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129051#comment-15129051
]
ASF GitHub Bot commented on BOOKKEEPER-841:
-------------------------------------------
Github user merlimat commented on a diff in the pull request:
https://github.com/apache/bookkeeper/pull/5#discussion_r51636808
--- Diff:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
---
@@ -101,14 +114,60 @@ public long getLogId() {
private final CopyOnWriteArrayList<EntryLogListener> listeners
= new CopyOnWriteArrayList<EntryLogListener>();
+ private static final int HEADER_V0 = 0; // Old log file format (no
ledgers map index)
+ private static final int HEADER_V1 = 1; // Unrecognized header version
--- End diff --
True, I left the wrong comment when refactoring.
> Bookie should calculate ledgers map writing a new entry log file
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-841
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-841
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Matteo Merli
> Fix For: 4.4.0
>
> Attachments:
> 0001-BOOKKEEPER-841-Bookie-should-calculate-ledgers-map-w.patch,
> 0001-BOOKKEEPER-841-Bookie-should-calculate-ledgers-map-w.patch,
> 0001-BOOKKEEPER-841-Bookie-should-calculate-ledgers-map-w.patch,
> 0001-BOOKKEEPER-841-Bookie-should-calculate-ledgers-map-w.patch
>
>
> Bookie should calculate ledgers map when writing a new entry log file. so the
> bookie doesn't need to scan that entry log file again, which it would improve
> garbage collection efficiency
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
