[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132842#comment-15132842
 ] 

ASF GitHub Bot commented on BOOKKEEPER-883:
-------------------------------------------

GitHub user sijie opened a pull request:

    https://github.com/apache/bookkeeper/pull/10

    BOOKKEEPER-883: Test timeout in bookkeeper-benchmark

    Problem:
    
    The BenchReadThroughputLatency is tight with FlatLedgerManager. so lots of 
assumptions are made based on how the znodes are changed when ledgers are 
created. There was a change introduced LedgerIdGenerator, which broke the 
assumptions that made by BenchReadThroughputLatency.
    
    Fix:
    
    - Use a hashset to cache processed ledgers on reacting on children changes
    - Remove unpredictable test on next ledger
    - Fix an error logging on FlatLedgerManager processing ledgers

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/bookkeeper BOOKKEEPER-883

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit e9961f2730495974b8cd322665b242fe2c90075f
Author: Sijie Guo <[email protected]>
Date:   2016-02-04T19:12:57Z

    BOOKKEEPER-883: Test timeout in bookkeeper-benchmark
    
    Problem:
    
    The BenchReadThroughputLatency is tight with FlatLedgerManager. so lots of 
assumptions are made based on how the znodes are changed when ledgers are 
created. There was a change introduced LedgerIdGenerator, which broke the 
assumptions that made by BenchReadThroughputLatency.
    
    Fix:
    
    - Use a hashset to cache processed ledgers on reacting on children changes
    - Remove unpredictable test on next ledger
    - Fix an error logging on FlatLedgerManager processing ledgers

----


> Test timeout in bookkeeper-benchmark
> ------------------------------------
>
>                 Key: BOOKKEEPER-883
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-883
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.4.0, 4.2.4
>
>
> bookkeeper-benchmark tests usually timeout



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to