Looks fine to me too. :) On Tue, Mar 15, 2016 at 9:11 PM, ASF GitHub Bot (JIRA) <[email protected]> wrote:
> > [ > https://issues.apache.org/jira/browse/BOOKKEEPER-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196724#comment-15196724 > ] > > ASF GitHub Bot commented on BOOKKEEPER-895: > ------------------------------------------- > > Github user sijie commented on the pull request: > > https://github.com/apache/bookkeeper/pull/25#issuecomment-197143797 > > the patch looks good to me. only one minor comment. > > > > bookies should not retain ledgers which no longer belong to them > > ---------------------------------------------------------------- > > > > Key: BOOKKEEPER-895 > > URL: > https://issues.apache.org/jira/browse/BOOKKEEPER-895 > > Project: Bookkeeper > > Issue Type: Improvement > > Components: bookkeeper-server > > Affects Versions: 4.3.2 > > Reporter: Siddharth Sunil Boobna > > Assignee: Siddharth Sunil Boobna > > > > The bookies do not clean up ledgers on their disk which exist in > zookeeper but are not assigned to them by the ensemble definition. This > happens if a bookie has a ledger, went offline, it was replicated > elsewhere, and then the bookie comes back up. Then we have an extra copy of > the same ledger. > > Solution: > > Bookie should handle this case in the garbage collector. Since we will > have to read the ledger metadata and go through its ensemble set to > determine if the bookie exists in the ensemble, this is an expensive > operation. Thus, we will only run this task once every day. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi
