[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227114#comment-15227114
 ] 

Hadoop QA commented on BOOKKEEPER-910:
--------------------------------------

Testing JIRA BOOKKEEPER-910


Patch 
[0001-Use-loopback-IP-address-for-Zookeeper-in-LocalBookke.patch|https://issues.apache.org/jira/secure/attachment/12797141/0001-Use-loopback-IP-address-for-Zookeeper-in-LocalBookke.patch]
 downloaded at Tue Apr  5 19:53:48 UTC 2016

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.    {color:red}WARNING{color}: the current HEAD has 13 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs 
warnings
.    {color:red}WARNING: the current HEAD has  Findbugs warning(s), they should 
be addressed ASAP{color}
{color:red}-1 TESTS{color}
.    Tests run: 667
.    Tests failed: 3
.    Tests errors: 3

.    The patch failed the following testcases:

.      
testRWZKSessionLost[0](org.apache.bookkeeper.replication.TestReplicationWorker)
.      
testRWZKSessionLost[1](org.apache.bookkeeper.replication.TestReplicationWorker)
.      
testRWZKSessionLost[2](org.apache.bookkeeper.replication.TestReplicationWorker)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}.   There is at least one warning, please check{color}

The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/980/

> In LocalBookkeeper, Zookeeper server and client use different host addresses
> ----------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-910
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-910
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.3.2
>            Reporter: Arun M. Krishnakumar
>            Assignee: Arun M. Krishnakumar
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 4.4.0
>
>         Attachments: 
> 0001-Use-loopback-IP-address-for-Zookeeper-in-LocalBookke.patch
>
>
> In LocalBookkeeper, the Zookeeper server is started at 127.0.0.1 and the 
> client tries to derive the localhost address using getLocalHost API. This has 
> a few issues:
> 1. There is a possibility of using the ipv6 address for localhost and hence 
> the client will try connecting to ::1, 2181 rather than 127.0.0.1:2181 (this 
> happens commonly on OSX)
> 2. The getLocalHost API could sometimes return non-loopback addresses as well.
> Since the 'localbookie' mode is used with the zookeeper in the same machine, 
> we should use loopback addresses for all invocations. The patch does just 
> that.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to