[
https://issues.apache.org/jira/browse/BOOKKEEPER-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232129#comment-15232129
]
Enrico Olivelli commented on BOOKKEEPER-917:
--------------------------------------------
Just adding a check for LocalChannel fixes the test, mabye it would but I this
it is better to search usages of getRemoteAddress and fix all the cases.
On ServerSideHandler class
{code}
@Override
public void channelOpen(ChannelHandlerContext ctx,
ChannelStateEvent e) throws Exception {
if (ctx.getChannel() instanceof LocalChannel) {
authProvider = authProviderFactory.newProvider(null,
new AuthHandshakeCompleteCallback());
} else {
SocketAddress remote = ctx.getChannel().getRemoteAddress();
if (remote instanceof InetSocketAddress) {
authProvider =
authProviderFactory.newProvider((InetSocketAddress) remote,
new AuthHandshakeCompleteCallback());
} else {
LOG.error("Unknown socket type {} for {}",
remote.getClass(), remote);
}
}
super.channelOpen(ctx, e);
}
{code}
On ClientSideHandler class
{code}
@Override
public void channelConnected(ChannelHandlerContext ctx,
ChannelStateEvent e)
throws Exception {
if (ctx.getChannel() instanceof LocalChannel) {
authProvider = authProviderFactory.newProvider(null,
new AuthHandshakeCompleteCallback(ctx));
authProvider.init(new AuthRequestCallback(ctx));
} else {
SocketAddress remote = ctx.getChannel().getRemoteAddress();
if (remote instanceof InetSocketAddress) {
authProvider =
authProviderFactory.newProvider((InetSocketAddress) remote,
new AuthHandshakeCompleteCallback(ctx));
authProvider.init(new AuthRequestCallback(ctx));
} else {
LOG.error("Unknown socket type {} for {}",
remote.getClass(), remote);
}
}
super.channelConnected(ctx, e);
}
{code}
> LocalBookKeeperTest seems to be silently failing
> ------------------------------------------------
>
> Key: BOOKKEEPER-917
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-917
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.4.0
> Reporter: Flavio Junqueira
> Assignee: Matteo Merli
> Priority: Critical
> Fix For: 4.4.0
>
>
> I've noticed this while inspecting the output in jenkins:
> {noformat}
> Running org.apache.bookkeeper.client.BookKeeperCloseTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.074 sec
> Running org.apache.bookkeeper.client.LocalBookKeeperTest
> Running org.apache.bookkeeper.meta.GcLedgersTest
> {noformat}
> It sounds like {{LocalBookKeeperTest}} is failing silently. Is it hanging and
> timing out?
> https://builds.apache.org/job/bookkeeper-master-git-pullrequest/57/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
