[
https://issues.apache.org/jira/browse/BOOKKEEPER-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233592#comment-15233592
]
ASF GitHub Bot commented on BOOKKEEPER-904:
-------------------------------------------
Github user fpj commented on the pull request:
https://github.com/apache/bookkeeper/pull/30#issuecomment-207806494
+1, LGTM.
> test BookieInitializationTest.testDuplicateBookieServerStartup fails on
> non-english machines
> --------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-904
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-904
> Project: Bookkeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 4.4.0
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Trivial
> Fix For: 4.4.0
>
>
> The test checks for message "Address already in use", which is "Indirizzo giĆ
> in uso" in Italian.
> Maybe it is enough to catch BindException and remove the assertion
> {code}
> Assert.assertTrue("BKServer allowed duplicate startups!",
> ce.getCause().getMessage().contains("Address already in
> use"));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)