I usually do that but forgot on that one PR. OTOH, it might be good to extend the merge script (dev/bk-merge-pr.py) to automatically leave a comment on the Jira with info on the committer, reviewers, etc..
Matteo On Sat, Apr 9, 2016 at 9:07 AM Sijie Guo <[email protected]> wrote: > Yup. We should +1 before merging. > > On Sat, Apr 9, 2016 at 9:29 AM, Flavio Junqueira <[email protected]> wrote: > > > I was having a look at BK-904 and couldn't determine from jira or the > pull > > request who reviewed and merged. By looking at the log, I can see it was > > Matteo. > > > > For committers: please +1 any issue before merging it either on the pull > > request or jira. > > > > -Flavio >
