[
https://issues.apache.org/jira/browse/BOOKKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337488#comment-15337488
]
ASF GitHub Bot commented on BOOKKEEPER-930:
-------------------------------------------
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/49
in general, this looks good to me. But I would suggest doing as follows:
- extend BookieNettyServer to VMLocalBookieNettyServer, override the
methods to not listen on port
- it would also be nice to do similar for the existing VMLocal part
As adding more flags would grow the complexity of this piece of code, I
would suggest trying to avoid it.
`
class BookieNettyServer {
BookieNettyServer(..) {
...
the serverChannelFactory = createServerChannelFactroy();
...
}
ServerChannelFactroy createServerChannelFactory() {
...
}
}
class VMLocalBookieNettyServer extends BookieNettyServer {
// override createServerChannel
// override listenOn
// override close
}
`
> Option to disable Bookie networking
> -----------------------------------
>
> Key: BOOKKEEPER-930
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-930
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-server
> Affects Versions: 4.4.0
> Reporter: Enrico Olivelli
> Priority: Minor
>
> This issue is related to BOOKKEEPER-896 which introduced the ability to use
> Netty built-in local channels.
> The idea is to disable Bookie networking for networkless JUnit testing.
> We can introduce a "disableServerSocketBind" option to skip server-side bind
> at BookieNettyServer#listenOn
> Another use case is to use BookKeeper as write-ahead log for single machine
> applications
> Note:
> ZookKeeper still needs network but this is another issue
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
