[
https://issues.apache.org/jira/browse/BOOKKEEPER-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877682#comment-15877682
]
ASF GitHub Bot commented on BOOKKEEPER-1004:
--------------------------------------------
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/109
@govind-menon I'm sorry but in your actual code on the PR inside the
shutdown() method there is still the 'wait(100)'.
OK for the '100' but we should use Thread.sleep(100) as IMHO 'Object#wait'
should be used inside a 'synchronized' block.
What do you think ?
> Allow bookie garbage collection to be triggered manually from tests
> -------------------------------------------------------------------
>
> Key: BOOKKEEPER-1004
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1004
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.5.0, 4.6.0
> Reporter: Govind Menon
> Priority: Minor
> Labels: test
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current gc tests rely on waiting on a timeout for gc to run. It's
> never certain whether it has run or not or if it's still running.
> This patch allows tests to trigger a gc run and gives the client
> a future to know when it has completed. The gc algorithm is unchangedI but
> now it runs in a scheduled executor rather than as a
> Thread.
> This work was originally done by Ivan Kelly and I am just pushing it back to
> open source
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
