[
https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937614#comment-15937614
]
ASF GitHub Bot commented on BOOKKEEPER-1008:
--------------------------------------------
Github user kishorekasi commented on the issue:
https://github.com/apache/bookkeeper/pull/116
I am currently little busy with another priority at work and haven't spent
time on this in the past week. I hope to get back to this soon.
Kishore
On Wed, Mar 22, 2017 at 7:52 PM, Sijie Guo <[email protected]> wrote:
> *@sijie* commented on this pull request.
> ------------------------------
>
> In bookkeeper-server/src/main/java/org/apache/bookkeeper/
> client/BookKeeper.java
> <https://github.com/apache/bookkeeper/pull/116#discussion_r107578730>:
>
> > @@ -225,10 +233,10 @@ private static ZooKeeper
validateZooKeeper(ZooKeeper zk) throws NullPointerExcep
> return zk;
> }
>
> - private static ClientSocketChannelFactory
validateChannelFactory(ClientSocketChannelFactory factory)
> + private static EventLoopGroup validateChannelFactory(EventLoopGroup
eventLoopGroup)
>
> +1 on this comment. we should rename it.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/bookkeeper/pull/116#discussion_r107578730>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ADKY-FXN33zwvxDmGD7qUF66sfcNbMFRks5rod6KgaJpZM4McUUZ>
> .
>
> Move to netty4
> --------------
>
> Key: BOOKKEEPER-1008
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1008
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.5.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> As part of the Yahoo push back and in general we would like to move to netty
> 4, preferably netty 4.1.x for the client and server communication.
> This lays the ground work for zero copy, or very nearly zero copy handling on
> the server side.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
