[
https://issues.apache.org/jira/browse/BOOKKEEPER-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938508#comment-15938508
]
ASF GitHub Bot commented on BOOKKEEPER-1013:
--------------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/118
> Fix findbugs errors on latest master
> ------------------------------------
>
> Key: BOOKKEEPER-1013
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1013
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.5.0
>
>
> The multiple journal dirs change and explict-lac change introduced a few
> findbug errors.
> {code}
> [INFO] BugInstance size is 8
> [INFO] Error size is 0
> [INFO] Total bugs: 8
> [INFO] org.apache.bookkeeper.bookie.CheckpointSourceList$CheckpointList
> defines compareTo(Object) and uses Object.equals()
> [org.apache.bookkeeper.bookie.CheckpointSourceList$CheckpointList] At
> CheckpointSourceList.java:[line 53] EQ_COMPARETO_USE_OBJECT_EQUALS
> [INFO] Dead store to ledgerId in
> org.apache.bookkeeper.bookie.FileInfo.setExplicitLac(ByteBuffer)
> [org.apache.bookkeeper.bookie.FileInfo] At FileInfo.java:[line 140]
> DLS_DEAD_LOCAL_STORE
> [INFO] Inconsistent synchronization of
> org.apache.bookkeeper.bookie.FileInfo.explicitLac; locked 85% of time
> [org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo, org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo, org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo, org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo, org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo, org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo, org.apache.bookkeeper.bookie.FileInfo,
> org.apache.bookkeeper.bookie.FileInfo] Unsynchronized access at
> FileInfo.java:[line 118]Unsynchronized access at FileInfo.java:[line
> 145]Synchronized access at FileInfo.java:[line 121]Synchronized access at
> FileInfo.java:[line 122]Synchronized access at FileInfo.java:[line
> 123]Synchronized access at FileInfo.java:[line 124]Synchronized access at
> FileInfo.java:[line 125]Synchronized access at FileInfo.java:[line
> 134]Synchronized access at FileInfo.java:[line 137]Synchronized access at
> FileInfo.java:[line 138]Synchronized access at FileInfo.java:[line
> 140]Synchronized access at FileInfo.java:[line 135]Synchronized access at
> FileInfo.java:[line 141]Synchronized access at FileInfo.java:[line 143]
> IS2_INCONSISTENT_SYNC
> [INFO] Inconsistent synchronization of
> org.apache.bookkeeper.client.LedgerHandle.length; locked 90% of time
> [org.apache.bookkeeper.client.ReadOnlyLedgerHandle$MetadataUpdater,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerHandle,
> org.apache.bookkeeper.client.LedgerRecoveryOp,
> org.apache.bookkeeper.client.LedgerHandle$2] Unsynchronized access at
> ReadOnlyLedgerHandle.java:[line 59]Synchronized access at
> LedgerHandle.java:[line 259]Synchronized access at LedgerHandle.java:[line
> 777]Synchronized access at LedgerHandle.java:[line 777]Synchronized access at
> LedgerHandle.java:[line 1360]Synchronized access at LedgerHandle.java:[line
> 249]Synchronized access at LedgerHandle.java:[line 249]Synchronized access at
> LedgerHandle.java:[line 250]Synchronized access at LedgerHandle.java:[line
> 976]Synchronized access at LedgerRecoveryOp.java:[line 151]Synchronized
> access at LedgerHandle.java:[line 379] IS2_INCONSISTENT_SYNC
> [INFO] Redundant nullcheck of journalDirNames, which is known to be non-null
> in org.apache.bookkeeper.conf.ServerConfiguration.getJournalDirs()
> [org.apache.bookkeeper.conf.ServerConfiguration] Redundant null check at
> ServerConfiguration.java:[line 631] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> [INFO] Argument of type String[] formatted in useless way in
> org.apache.bookkeeper.proto.BookieServer.main(String[])
> [org.apache.bookkeeper.proto.BookieServer] At BookieServer.java:[line 420]
> VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY
> [INFO] Dead store to entrySize in
> org.apache.bookkeeper.proto.PerChannelBookieClient.writeLac(long, byte[],
> long, ChannelBuffer, BookkeeperInternalCallbacks$WriteLacCallback, Object)
> [org.apache.bookkeeper.proto.PerChannelBookieClient] At
> PerChannelBookieClient.java:[line 390] DLS_DEAD_LOCAL_STORE
> [INFO] Futile attempt to change max pool size of ScheduledThreadPoolExecutor
> in new org.apache.bookkeeper.util.OrderedSafeExecutor(String, int,
> ThreadFactory, StatsLogger, boolean, long)
> [org.apache.bookkeeper.util.OrderedSafeExecutor] At
> OrderedSafeExecutor.java:[line 186]
> DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR
> [INFO]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
