[
https://issues.apache.org/jira/browse/BOOKKEEPER-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954133#comment-15954133
]
ASF GitHub Bot commented on BOOKKEEPER-1021:
--------------------------------------------
GitHub user sijie opened a pull request:
https://github.com/apache/bookkeeper/pull/123
BOOKKEEPER-1021: Improve merge script to handle github reviews api
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/bookkeeper sijie/improve_merge_scripts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit b710d500ff439cb02d117ffa7b59090cdc7c5bfd
Author: Sijie Guo <[email protected]>
Date: 2017-03-22T23:47:26Z
Improve merge script
commit e339aa8f1453627d12a2e31206593a96c235d675
Author: Sijie Guo <[email protected]>
Date: 2017-03-23T03:47:59Z
Fix Findbugs Errors
commit 8ab205f40164931d97e7032f6bdebe6423c022d0
Author: Sijie Guo <[email protected]>
Date: 2017-04-03T19:22:01Z
BOOKKEEPER-1021: Improve merge script to handle github reviews api
commit 13746a2aa7918610b115adf206a5f48d1820a739
Author: Sijie Guo <[email protected]>
Date: 2017-04-03T19:22:43Z
Merge branch 'master' into sijie/improve_merge_scripts
commit a66f26e30eae2a72945a0580bbb5fdb54d257f2e
Author: Sijie Guo <[email protected]>
Date: 2017-04-03T19:24:11Z
fix
commit 6029c8ef88527bfa601813189b91c5f2012651f3
Author: Sijie Guo <[email protected]>
Date: 2017-04-03T19:29:29Z
fix
commit 8cb62dc9f3120006f0180d6b3d39f5206b390c0f
Author: Sijie Guo <[email protected]>
Date: 2017-04-03T20:36:40Z
Merge remote-tracking branch 'origin/master' into
sijie/improve_merge_scripts
----
> Improve the merge script to handle github reviews api
> -----------------------------------------------------
>
> Key: BOOKKEEPER-1021
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1021
> Project: Bookkeeper
> Issue Type: Bug
> Components: build
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.5.0
>
>
> Current script doesn't handle the new reviews API.
> We need to improve the merge script to handle the new review API.
> https://developer.github.com/v3/pulls/reviews/
> We can do similar thing like what DistributedLog is doing.
> https://github.com/apache/incubator-distributedlog/blob/master/scripts/dev/dl-merge-pr.py
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
