[
https://issues.apache.org/jira/browse/BOOKKEEPER-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980814#comment-15980814
]
ASF GitHub Bot commented on BOOKKEEPER-1010:
--------------------------------------------
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/117
@arvindkandhare I have addressed all the issue.
Basically you forget to add an "include" clause in compat dependencies poms
and relocate all guava classes.
As a class (HostAndPort) has been marked as "deprecate" a SuppressWarnings
annotation needs to be added in the CodahaleMetricsProvider
I have pushed a working branch here
https://github.com/eolivelli/bookkeeper/tree/guava_version
You can take the last commit
https://github.com/eolivelli/bookkeeper/commit/b3d0ae8627c03356e1fd450326a5ef100f5b05dd
I hope that helps
The last thing to do is to ensure that Guava is not used in any "public"
API (BookKeeper,LedgerHandler, Auth Plugin API, LedgerManager API,
EnsemblePlacement API...and so on)
Recently we had to break compatibility because Protobuf was "shaded" and
used in the Auth Plugin API explicitly
> Bump up Guava version to 20.0
> -----------------------------
>
> Key: BOOKKEEPER-1010
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1010
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Arvind Kandhare
>
> Currently bookkeeper is using Guava 13.0. Guava has moved forward and at
> version 20.0 there are some API changes.
> This becomes an issue if a project using Guava 20.0 tries to run bookie
> server inproc. Bumping the Guava version to 20.0 will fix that issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
