[
https://issues.apache.org/jira/browse/BOOKKEEPER-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Olivelli resolved BOOKKEEPER-1021.
-----------------------------------------
Resolution: Fixed
Yes it is OK now.
I noticed that GitHub does not give access to user emails of other users
anymore.
If I use my own Oauth token my email as "reviewer" is returned.
I wonder If we can drop the reviewer email from commit messages (actually I am
often rewriting the message dropping the <None> strings)
> Improve the merge script to handle github reviews api
> -----------------------------------------------------
>
> Key: BOOKKEEPER-1021
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1021
> Project: Bookkeeper
> Issue Type: Bug
> Components: build
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.5.0
>
>
> Current script doesn't handle the new reviews API.
> We need to improve the merge script to handle the new review API.
> https://developer.github.com/v3/pulls/reviews/
> We can do similar thing like what DistributedLog is doing.
> https://github.com/apache/incubator-distributedlog/blob/master/scripts/dev/dl-merge-pr.py
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
