GitHub user sijie opened a pull request:
https://github.com/apache/bookkeeper/pull/172
BOOKKEEPER-1084: Make variables finale if necessary
not all logger in bookkeeper & hedwig are static. some class like
PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so
this task is to make logger as a static variable if it didn't.
with benefit, cleaning up the imports when touching that file.
RB_ID=141138
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/bookkeeper make_finale
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit daffc8460670cd15994bb8650add3be5a9dc2eef
Author: Sijie Guo <sij...@twitter.com>
Date: 2013-04-19T00:54:55Z
make logger as a static variable
not all logger in bookkeeper & hedwig are static. some class like
PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so
this task is to make logger as a static variable if it didn't.
with benefit, cleaning up the imports when touching that file.
RB_ID=141138
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
