Hi Jia, I just granted you the permissions. Do you mind starting a separate email thread? I think this one is about pre-commit builds for pull requests.
- Sijie On Fri, Jun 9, 2017 at 8:12 PM, Jia Zhai <zhaiji...@gmail.com> wrote: > Hi Sijie, Flavio and Enrico, > I prepared a BP for this "Github issues", would you please help comment on > it? And seems I did not have write permission, Would please help add it in > https://cwiki.apache.org/confluence/display/BOOKKEEPER/ > BookKeeper+Proposals > ? If could get the permission, it is better, :), My wiki Id is "zhaijia". > > Thanks a lot. > -Jia > > ========= > BP-9 - Trying out Github issues for Issue Tracking > =========Problem > > - > > Community have voted and decided to start using Github issues/pull > requests for issue tracking for 3 months. > - > > however, It needs some github permissions and some simple/basic rules to > follow. > > Proposal > > - > > Github Issue and Pull Requests > - > > We can use Issue/Pull Request templates ( > https://github.com/blog/2111-issue-and-pull-request-template > <https://github.com/blog/2111-issue-and-pull-request-templates> )to > give user instructions on what should be described in issues and pull > requests. Here are two attached templates. > - > > Issue template > <https://gist.github.com/jiazhai/fda5fa04b5a12b555c5085752b2aaadb > >. > - > > Pull Request template > <https://gist.github.com/jiazhai/3c2fbc42adb7daf5fa2f588982210721 > >. > - > > If a change is trivial, or you have the code ready, you can open a PR > directly; otherwise create an issue for discussion before > starting writing > code. > - > > Issue Labeling > - > > Release - We can use “milestone” for managing releases. > - > > We can start with minimal labels, iterate and add more if the labels > are really needed. > - > > Type/Kind: {bug, feature, task} > - > > Component/Area: {protocol, client, bookie, tests, documentation} > - > > Priority: {blocker}. If it is a blocker, mark it a blocker. > Otherwise leaves it unmarked. > - > > Closing the PR > - > > Ask INFRA if we have the permission to merge directly in Github. > - > > If we have, enable “allow squash merging”, disable “allow merge > commits” and “allow rebase merging” to make a clean commit history. > - > > If we don’t have the permission, improving the merge-script to close > both issue and PR > - > > Currently the script closes the PR using commit messages ( > https://help.github.com/articles/closing-issues-via- > commit-messages/), > we need to improve the script to be able to find its > corresponding issue, > if there is one. > > Action > > - > > Requests corresponding permissions from INFRA > - > > Permissions for committers to create labels and milestones > - > > Permission for merge and close issues/pull requests > - > > Add Issue and RP template under .github > - > > Change to merge script to close PR and Issue > - > > Update the pull request instruction at both website and wiki page > ========== > > > On Fri, Jun 9, 2017 at 6:41 PM, Enrico Olivelli <eolive...@gmail.com> > wrote: > > > 2017-06-09 12:37 GMT+02:00 Enrico Olivelli <eolive...@gmail.com>: > > > 2017-06-09 12:25 GMT+02:00 Enrico Olivelli <eolive...@gmail.com>: > > >> > > >> > > >> Il ven 9 giu 2017, 12:04 Sijie Guo <guosi...@gmail.com> ha scritto: > > >>> > > >>> On Fri, Jun 9, 2017 at 1:51 AM, Enrico Olivelli <eolive...@gmail.com > > > > >>> wrote: > > >>> > > >>> > Hi, > > >>> > I would like to ask infra permissions to edit pull requests of > other > > >>> > users, at least "close"/"reopen" to force automatic QA. > > >>> > > > >>> > > >>> You can manually trigger the pre-commit job to build a specific pull > > >>> request. There is one parameter and an example when you try to build > it > > >>> with parameters. > > >> > > >> > > >> I will check. Do you mean that this parameter is in jenkins web ui? > > > > > > Got it > > > > > > you have to click on "rebuild" and then write the ref like: > > > > > > pull/183/head > > > > actually syntax is > > origin/pr/183/head as the example tells on the web ui > > > > thanks > > > > -- Enrico > > > > > > > > it is correct ? > > > > > >>> > > >>> > > >>> > > >>> > > > >>> > We have a short backlog of PR QA builds so after some time it is > not > > >>> > possible to see old tests results > > >>> > > >>> > > >>> > Maybe this permission can be extended automatically to every > > committer > > >>> > of the project. > > >>> > > > >>> > I think that not every of us (committers) has bound his github > > account > > >>> > to the apache id, in fact when you are "linked" in the comments on > > PRs > > >>> > you are listed as "member", otherwise as "contributor") > > >>> > > > >>> > > >>> I think it is fine. There is no much difference between "member" and > > >>> "contributor". It is a preference up to the committers themselves. > > >>> > > >>> > > >>> > > > >>> > Thoughts ? > > >>> > > > >>> > Enrico > > >>> > > > >> > > >> -- > > >> > > >> > > >> -- Enrico Olivelli > > >
