[
https://issues.apache.org/jira/browse/BOOKKEEPER-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061566#comment-16061566
]
Sijie Guo commented on BOOKKEEPER-1099:
---------------------------------------
[~zshi] just to clarify what I said: I am fine with providing any tools in
BookKeeperAdmin or BookieShell that simplifies your logic. My concern is not
putting *such logic* into bookie startup code. The bookie startup code should
just hold a simple deal: Give me a few directories to start, I start up only
when I find the directories and the directories have the proper cookies (to
prevent any mistakes happening). If there is anything wrong (directories are
missing, cookies are missing), I should not start.
There are some operations should only execute once - for example, 'metaformat'
should only happen once when setting up the cluster, 'bookieformat' should only
happen once when adding a bookie to a cluster. Putting such logic in the code
and execute everytime the bookie process is restarted, is dangerous. 'InitFold'
is a similar thing - it might not be a big deal as 'metaformat' and
'bookieformat'. But it is still concerned since it might potentially
misconfigured the disk layout in the way that you are not expecting.
It is not my decision. It is a community project, if there are other people
feeling this is okay, I am fine with that. so it is a -0 from me.
> Make bookie automatically create folders on new machine.
> --------------------------------------------------------
>
> Key: BOOKKEEPER-1099
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1099
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Zhimeng Shi
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When bookie start and found it need run bookie format to create folders it
> should do that automatically. That way will make new machine deployment and
> machine replacement process much simpler without manually call the
> bookieformat command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
