GitHub user kishorekasi opened a pull request:
https://github.com/apache/bookkeeper/pull/214
Fix ByteBuf refcount release
- Release ByteBuf in Replicator
- Do not release refcnt in PCBC upon addEntry error
- Remove unnecessary ByteBuf refcnt retain in Bookie protocol (V2) request
encoding
Descriptions of the changes in this PR:
Addressing test failure - TestBackwardCompat.testCompat410 often fails due
to io.netty.util.IllegalReferenceCountException (#198)
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`<Issue #>: Description of pull request`
`e.g. Issue 123: Description ...`
- [ ] Make sure tests pass via `mvn clean apache-rat:check install
findbugs:check`.
- [ ] Replace `<Issue #>` in the title with the actual Issue number, if
there is one.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorekasi/bookkeeper testfailure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #214
----
commit bd492f2548a464d0d874710f33770c5a74145017
Author: Kishore Kasi Udayashankar <[email protected]>
Date: 2017-06-06T08:19:33Z
Fix ByteBuf refcount release
- Release ByteBuf in Replicator
- Do not release refcnt in PCBC upon addEntry error
- Remove unnecessary ByteBuf refcnt retain in Bookie protocol (V2) request
encoding
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
