[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066056#comment-16066056
 ] 

ASF GitHub Bot commented on BOOKKEEPER-1033:
--------------------------------------------

Github user sijie commented on the issue:

    https://github.com/apache/bookkeeper/pull/189
  
    @jvrao @reddycharan 
    
    one more question, most of the comments are around the performance on 
journal directories. but it turns out this change has nothing to do with the 
journal directories. The change applies only on the ledger directories and 
index directories. if that's the case, I don't see a reason to have this 
configuration. because random I/O anyway exists on ledger and index 
directories, there isn't any performance difference between configuring one 
directory per disk partition or multiple directories per disk partition. 
Filesystem I/O scheduling will handle either case in the same way. so this 
doesn't sound like an operation error as what @jvrao said.
    
    so back to the question, what is the problem that this pull request want to 
address? 
    
    - if the problem is about the mis-reported disk metrics, this can be done 
smarter by de-duplicating the directories within ledger disks and report the 
per disk partition metrics.
    - if the problem is about performance, multiple ledger/index disks on same 
partition doesn't have any performance difference with one ledger/index disk 
per disk partition. this doesn't sound like an operation error that needs to be 
fixed.
    - if the problem is about performance on journal disks, I am fine with such 
setting. but this pull request need to improve to address the right problem.
    
    



> Handle DirsPartitionDuplication
> -------------------------------
>
>                 Key: BOOKKEEPER-1033
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1033
>             Project: Bookkeeper
>          Issue Type: New Feature
>            Reporter: Charan Reddy Guttapalem
>            Assignee: Charan Reddy Guttapalem
>
> - Provide configuration for allowDirsPartitionDuplication
> - while calculating total disk metrics account Partition Duplication



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to