sijie commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312048837 I am okay with using a checkstyle plugin. it shouldn't be a big deal with existing pull requests. I am fine with merging this change and having a separate follow up jira to enable checkstyle plugin. Since DistributedLog is graduated as a subproject of BookKeeper, and there is already checkstyle rules in DistributedLog, it would be good to reuse the checkstyle rules there. https://github.com/apache/incubator-distributedlog/blob/master/distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
