2017-07-04 5:51 GMT+02:00 Jia Zhai <[email protected]>: > Agree to have them protected. > Currently, seems these branches are not protected, at least master branch > is not. The merge button is still available even "Jenkins: Maven clean > install — Build finished." in some of PRs > <https://github.com/apache/bookkeeper/pulls> > We may first need to make the test stable.
I think that is it enough to only protect against "force push", which makes impossible for anyone to 'rewrite' the "public history" of the project Other checks are performed by QA test and by the committer who takes responsibility for pushing the patch in the repo -- Enrico > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <[email protected]> wrote: > >> Hi, >> I don't know current configuration but I would like to ensure that our >> release branches, that is master and branch-xx are 'protected'. >> I mean at least that 'force push' must be forbidden to everyone. >> >> In github it is simple to enable such protection, see >> https://help.github.com/articles/about-protected-branches/ >> >> I don't want to try btyy performing a force push. Maybe we can ask infra >> about current configuration >> >> Thoughts? >> >> Enrico >> -- >> >> >> -- Enrico Olivelli >>
