sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry
fails with NPE with LedgerHandlerAdv
URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127822352
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -720,8 +720,7 @@ public void asyncAddEntry(final byte[] data, final
AddCallback cb,
* @param ctx
* some control object
*/
- public void asyncAddEntry(final long entryId, final byte[] data, final
AddCallback cb, final Object ctx)
- throws BKException {
+ public void asyncAddEntry(final long entryId, final byte[] data, final
AddCallback cb, final Object ctx) {
Review comment:
@eolivelli I don't remember the exact conversation I had with JV before. but
it is better not to mix these two semantics together.
I am not sure why we need an extra boolean field. You can simply override
the methods and fail the requests, can't you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
