jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still have one question of why we have 2 sub dirs -- "4.4.0", and "4.4.0-alpine", it seems not convient. This way contains a lot of duplicate code, and harder to maintain; and at last, when Create Automated Docker Build, only one Dockerfile is allowed provided to docker, we will have to make a decision to choose based on CentOS/Alpine sooner or later. Here are 2 raw ideas from my view: 1, Let's only keep the [alpine](https://www.brianchristner.io/docker-is-moving-to-alpine-linux/) version this time? 2, It maybe better to place the version info(4.4.0) into Makefile, and remove dir 4.4.0. It seems strange to me for dirs named by a version in master branch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
