caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-317041008 @jiazhai What are your concerns about this code duplication? I think providing a centos image for who is concerned about license and compatibility and an alpine one for who is concerned security and performances could be nice. There is no simple way to use only one copy of the files for both (you need to create a template to "compile" in respective files). On image versions I fear the branch solution could rapidly became very uncomfortable (and I think this is the reason I never seen it used, in main images). If you released 3 versions and find a dockerfile bug, you have to commit this change on every branch? (you than have one or more commits "detached" from the release tag, that is maybe a little dirty). I prefer @sijie solution with templates in order to reduce code duplication between different versions but I'm not closed to alternatives (even the branch one) if there is consensus. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
