sijie commented on a change in pull request #266: Issue 265: Add persistable
bookie status
URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891390
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java
##########
@@ -265,17 +275,23 @@ public void testDuplicateBookieServerStartup() throws
Exception {
new String[] { tmpDir.getPath() });
BookieServer bs1 = new BookieServer(conf);
bs1.start();
-
+ BookieServer bs2 = null;
// starting bk server with same conf
try {
- BookieServer bs2 = new BookieServer(conf);
+ bs2 = new BookieServer(conf);
bs2.start();
fail("Should throw BindException, as the bk server is already
running!");
} catch (BindException e) {
- // Ok
+ Assert.assertTrue("BKServer allowed duplicate startups!",
+ e.getMessage().contains("Address already in use"));
Review comment:
reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
