eolivelli commented on a change in pull request #278: BOOKKEEPER-1100: Add
module for Bookkeeper Http Endpoint
URL: https://github.com/apache/bookkeeper/pull/278#discussion_r129331345
##########
File path: bookkeeper-server/pom.xml
##########
@@ -217,11 +217,21 @@
<version>${netty.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-minikdc</artifactId>
- <version>2.7.3</version>
- <scope>test</scope>
- </dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-minikdc</artifactId>
+ <version>2.7.3</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.json</groupId>
Review comment:
please consider using http://json-b.net/ which is the current (brand new)
standard for Java-JSON mapping.
org.json is really bad.
otherwise we could use Jackson Mapper, which is actually the best
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services