eolivelli commented on a change in pull request #301: Issue-299
EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129768396
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/GenericEnsemblePlacementPolicyTest.java
##########
@@ -132,9 +132,9 @@ public void testReplaceBookie() throws Exception {
lh.addEntry(value);
}
}
- assertEquals(2, customMetadataOnNewEnsembleStack.size());
Review comment:
@sijie in usecases covered by me and my company I am already handling this
problem by falling back to DefaultEnsamblePlacementPolicy in case for
non-compatibility.
So I am tempted to close the issue as "won't fix".
I wonder if other companies will have such problems, we should make a clear
list of changes and maybe a guide to the migration to 4.5.
As you previously said this would be a 5.0 release, but let's stick to 4.5,
we want to close as soon as possible
are you ok with closing the issue as won't fix ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
