zhaijack commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319320624 - we should stick to IllegalStateException. before your recent change, the client is throwing IllegalStateException. we should use checkState rather than checkNull in LedgerEntry. - the useUpooled setting broke the EnDecoder for v2 protocol. I have a pull request to improve the tests, I will include this in that pull request. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
