+1 for dropping the profiles.
On Mon, Aug 13, 2018 at 12:24 AM, Sijie Guo <guosi...@gmail.com> wrote: > I have no problem with this proposal. I am fine with dropping the profiles. > > Sijie > > On Sun, Aug 12, 2018 at 2:53 AM Enrico Olivelli <eolive...@gmail.com> wrote: > >> Hi, >> Currently in order to build the full code you have to add -Dstream >> property, this in turn will activate the 'stream' profile. >> Additionally to run tests in 'stream' submodule you have to also add >> -DstreamTests. >> >> This is very annoying, and now that we are going to release the 'stream' >> storage module as first class citizen it does not make much sense. >> >> This additional profile makes it more complex project wide operations like >> the release procedure. >> For instance I broke master branch yesterday because I did not advance the >> version in poms in the stream submodule. >> >> It is giving a lot of problems on code coverage stuff as well, because we >> have a very complex configuration of surefire. >> >> My proposal is to drop those profiles and let the stream module to be built >> together with the other parts. >> >> >> For the ones like me that work only on bookkeeper-server this change won't >> affect every day work. >> >> I would prefer that Sijie do this change as he introduced those profiles >> and knowns very well all the tricks. >> >> Regards >> Enrico >> -- >> >> >> -- Enrico Olivelli >>
