Hi, I have committed this PR https://github.com/apache/bookkeeper/pull/1725
But in the commit log we have as "author" Sijie see this online https://github.com/apache/bookkeeper/commit/7da429ea0e4f29b11da532f269196047162053ef During the execution of the script it proposed Sijie as "Author" but I had changed it manually. The commit is mine and the change is okay To me it is okay, no matter about the 'ownership' of the commit, but we must pay attention in the future. Maybe there is a bug in the script now that we have switched to the new GitHub merge API. I apologize for having continued the procedure even if there was something strange. Below the the commit message Enrico Author: Enrico Olivelli <[email protected]> Date: Tue Oct 2 13:28:59 2018 +0200 Add optional compile time only annotations-api dependency dropped in JDK11 Descriptions of the changes in this PR: ### Motivation Java Annotations API has been dropped from JRE since JDK11. We should add it explicitly at compile time. As we are using only the 'Generated' annotation, which has "source" retention when can add the dependency as 'optional'. We are not re-distributing the JAR in binary packages. ### Changes Add 'optional' dependency wherever it is needed (all GRPC artifacts for instance) Master Issue: #1710 Author: Sijie Guo <[email protected]> Author: Enrico Olivelli <[email protected]> Reviewers: Ivan Kelly <[email protected]> This closes #1725 from eolivelli/fix/jdk11-add-annotations-api
