+1 (binding) * LICENSE & NOTICE look good. * Rat good * spotbugs good * checkstyle had some issues, finding configs, but I'm not worried about it * sha512 and gpg good * tests ran cleanly * ran pulsar master integration tests against it. all passed
Good work Sijie! -Ivan On Mon, Dec 3, 2018 at 8:19 PM Matteo Merli <mme...@apache.org> wrote: > > +1 > > * Check binary, checksums, and ran a localbookie > * Source, checked rat and compiled with tests > > -- > Matteo Merli > <mme...@apache.org> > > > On Fri, Nov 30, 2018 at 2:53 AM Sijie Guo <guosi...@gmail.com> wrote: > > > Hi everyone, > > > > Please review and vote on the release candidate #0 for the version 4.7.3, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.7.3-rc0" [4] with git sha > > 7a25ac301910271e80986e287db4595ae5f7785e > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Sijie > > > > [1] https://github.com/apache/bookkeeper/pull/1850 > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.3-rc0/ > > [3] > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1036/ > > [4] https://github.com/apache/bookkeeper/tree/v4.7.3-rc0 > >
