+1 (binding) (Ubuntu 16.06) - Sigs: GOOD - Licenses: GOOD - Binary packages boot?: Tested starting bookie with -server & -all packages. running bkctl simpletest against them. GOOD - checkstyle: GOOD - spotbugs: GOOD - rat: GOOD - test: GOOD - integration test: GOOD - Tested against pulsar master (unit tests, and selected integration tests): GOOD
= Minor issues = I spotted a view minor problems, so I created github issues for them. zkServers & metadataServerUri are both specified in the config file by default #1920 bkctl is shipping bin/bookkeeper #1921 bkctl simpletest fails silently #1922 src package is missing stream/clients/python/scripts/docker_build.sh #1923 standalone integration tests shouldn't run if -Dstream profile is omitted #1924 Good work Sijie! -Ivan On Wed, Jan 30, 2019 at 12:22 AM Matteo Merli <mme...@apache.org> wrote: > > +1 (binding) > > (MacOS 10.14) > Verified: > * Signatures > * Source package build > * Binary with localbookie > * Client library jars in Maven > > > -- > Matteo Merli > <mme...@apache.org> > On Mon, Jan 28, 2019 at 10:21 PM Jia Zhai <zhai...@apache.org> wrote: > > > > +1 (binding) > > > > Environment: macOS 10.14.2 > > > > > > - verified 4 packages checksum ( asc and sha all good) > > > > - the source package build and test all run successfully. > > > > - in both binary package(server & all), 'bin/bookkeeper standalone' and > > 'bin/bookkeeper shell bookiesanity' runs well. > > > > > > > > On Tue, Jan 29, 2019 at 12:26 AM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > +1 (binding) > > > > > > * Run tests on jdk8 + linux, all passed. > > > * Checked signatures, all okay > > > * Run localbookie and "standalone mode" (without testing storage service) > > > * Used with a downstream project and all tests are okay, but the > > > migration from 8.1 was a "little" painful but doable: > > > - old LedgerMetadata was repleaced with o.a.b.api.LedgerMetadata > > > - changes in EnsemblePlacementPolicy (expected, we are braking that > > > interface at every major version) > > > - TestStatsProvider moved to bookkeeper-common:tests artifact, I had > > > to fix a bunch of poms > > > > > > I have created a bunch of issues about running the bookie on JDK11, > > > not blocker for a release. > > > I have left a comment on the release notes PR, not blocker for a release. > > > > > > Thank you Sijie for putting all together ! > > > > > > Enrico > > > > > > Il giorno dom 27 gen 2019 alle ore 05:38 Sijie Guo <si...@apache.org> > > > ha scritto: > > > > > > > > Hi everyone, > > > > > > > > Please review and vote on the release candidate #1 for the version > > > > 4.9.0, > > > > as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which includes: > > > > * Release notes [1] > > > > * The official Apache source and binary distributions to be deployed to > > > > dist.apache.org [2] > > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > > * Source code tag "v4.9.0-rc1" [4] with git sha > > > > b0e3adfea04e7e65512cca54e8b63d197abf910c > > > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > > > Please download these packages and review this release candidate: > > > > > > > > - Review release notes > > > > - Download the source package (verify shasum, and asc) and follow the > > > > instructions to build and run the bookkeeper service. > > > > - Download the binary package (verify shasum, and asc) and follow the > > > > instructions to run the bookkeeper service. > > > > - Review maven repo, release tag, licenses, and any other things you > > > think > > > > it is important to a release. > > > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Thanks, > > > > Release Manager > > > > > > > > [1] https://github.com/apache/bookkeeper/pull/1910 > > > > [2] > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.0-rc1/ > > > > [3] > > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1038/ > > > > [4] https://github.com/apache/bookkeeper/tree/v4.9.0-rc1 > > >
