+1 (binding) verified checksums and signtures built with JDK 8 from stage sources
not blocker: we should update Copyright in NOTICE with 2019 (not it is 2018) not blocker: I had problems with a clean build with JDK11 I am sure BK is working on Java 11 in production, it is only a matter of Maven configuration, filed an issue: https://github.com/apache/bookkeeper/issues/2062 Enrico [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 29.880 s [INFO] Finished at: 2019-04-05T08:51:39+02:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on project bookkeeper-stats-api: MavenReportException: Error while generating Javadoc: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module. [ERROR] [ERROR] Command line was:............k-11/bin/javadoc @options [ERROR] [ERROR] Refer to the generated Javadoc files in 'i/bookkeeper-4.9.1/bookkeeper-stats/target/apidocs' dir. [ERROR] Il giorno gio 4 apr 2019 alle ore 22:17 Ivan Kelly <iv...@apache.org> ha scritto: > > Sorry about the delay on getting to this, Enrico. > > +1 (binding) > > ✓ tag matches sha > ✓ check sha512 > ✓ check gpg > ✓ test licenses > ✓ rat check > ✓ compile -src > ✓ spotbugs > ✓ build tag > ✓ compiled tag matches -src > ✓ maven artifacts sigs are correct > ✓ unit tests > ✓ integration tests > > A few minor non-blocking things: > - The tag isn't signed which may be a good thing to add to the process. > - Building from -src, results in 2 maven artifacts that are not pushed to > nexus, > * > ./org/apache/bookkeeper/bookkeeper-server/4.9.1/bookkeeper-server-4.9.1-javadoc.jar > * > ./org/apache/bookkeeper/stats/bookkeeper-stats-api/4.9.1/bookkeeper-stats-api-4.9.1-javadoc.jar > > -Ivan
