Il sab 5 ott 2019, 03:22 Karan Mehta <k.me...@salesforce.com.invalid> ha scritto:
> @Enrico, Happy to take that up. Where do we do that? > > 1. Inside the code, before every public addEntry method > Here > 2. Your release notes PR > I will take care of this part > 3. Anything else? > No Thanks Enrico > > On Thu, Oct 3, 2019 at 10:36 PM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > Il gio 3 ott 2019, 23:52 Karan Mehta <k.me...@salesforce.com.invalid> ha > > scritto: > > > > > I see that you concluded on this issue > > > <https://github.com/apache/bookkeeper/issues/2138> with comment here > > > < > https://github.com/apache/bookkeeper/issues/2138#issuecomment-522099668 > > >, > > > however have we actually added any Javadoc for it? > > > > > > > Good catch Karan > > > > > > Can you please send a PR? > > > > > > Enrico > > > > > > > > > > > On Wed, Oct 2, 2019 at 1:09 AM Enrico Olivelli <eolive...@gmail.com> > > > wrote: > > > > > > > Hi, > > > > I see there is only one pending PR worth to commit before cutting > 4.10 > > > > > > > > It is from Charan > > > > https://github.com/apache/bookkeeper/pull/2166 > > > > > > > > I have already approved it, but I feel we need another eye on it. > > > > > > > > Just to make it clear, we have some old version of Netty and > ZooKeeper > > on > > > > current master, and there are pending CVEs over those libraries. > > > > > > > > We are close to the release, and some time ago, on Slack, Sijie and I > > > told > > > > that is it better to upgrade libraries only after starting the cycle > > for > > > > 4.11. > > > > I prefer to not upgrade those libraries now, and leave the change to > > the > > > > next release. > > > > > > > > On my products/projects I am already using latest and greatest Netty > > and > > > > ZooKeeper (and on JDK11,12,13) without issues. > > > > > > > > > > > > Best regards > > > > Enrico > > > > > > > > > > > > > -- > > > Karan Mehta > > > > > > <http://smart.salesforce.com/sig/k.mehta//us_mb/default/link.html> > > > > > > > > -- > Karan Mehta > > <http://smart.salesforce.com/sig/k.mehta//us_mb/default/link.html> >
