Enrico, LGTM. +1
- Sijie On Fri, Jan 3, 2020 at 10:49 PM David Rusek <dave.ru...@gmail.com> wrote: > Another option could be to create a Github bookkeeper org and host these as > separate projects under the same umbrella. I think this might be an option > for the future but I wanted to throw it out there. > > On Fri, Jan 3, 2020 at 7:43 AM David Rusek <dave.ru...@gmail.com> wrote: > > > +1 > > > > On Fri, Jan 3, 2020 at 5:57 AM Jia Zhai <zhaiji...@gmail.com> wrote: > > > >> +1 for me > >> > >> Best Regards. > >> > >> > >> Jia Zhai > >> > >> Beijing, China > >> > >> Mobile: +86 15810491983 > >> > >> > >> > >> > >> On Fri, Jan 3, 2020 at 6:46 PM Enrico Olivelli <eolive...@gmail.com> > >> wrote: > >> > >> > ping > >> > > >> > Il giorno sab 28 dic 2019 alle ore 17:15 Enrico Olivelli < > >> > eolive...@gmail.com> ha scritto: > >> > > >> > > Hi Bookkeepers, > >> > > I think that having the -Dstream profile is a nuisance. > >> > > It enables streamstorage and distributedlog modules. > >> > > > >> > > The release procedure enables it forcibly. > >> > > > >> > > On CI we have lots of tricks and we have a very complex structure of > >> > Maven > >> > > modules. > >> > > > >> > > Currently we also have a problem with LICENSE checker on Travis > >> > > https://github.com/apache/bookkeeper/pull/2228 > >> > > > >> > > When I work on bookkeeper-server module (main code) even if I enable > >> > > -Dstream I don't see troubles of any kind. > >> > > > >> > > Thoughts? > >> > > > >> > > Enrico > >> > > > >> > > >> > > -- > > > > Dave Rusek > > dave.ru...@gmail.com > > @davidjrusek > > > -- > > Dave Rusek > dave.ru...@gmail.com > @davidjrusek >
