+1 (binding) - Verified signatures and checksums - Build from source code (MacOS M3 JDK 17.0.9, Maven 3.8.6) - Build BookKeeper with Pulsar master (MacOS M3 JDK 17.0.9, Maven 3.8.6) - Build the Pulsar master branch that integrates with BookKeeper 4.16.4 rc0 and start the Pulsar cluster with one Zookeeper, one Bookie, and one broker. Run Pulsar perf produce and consume with DirectIO disabled -> enabled -> disabled. Everything works as expected. - All unit tests passed when the BookKeeper dependency of the Pulsar master branch was upgraded to 4.16.4. [1] - All the internal tests, which integrate with Pulsar, are passed
[1] https://github.com/hangc0276/pulsar/pull/24 Thanks, Hang Enrico Olivelli <eolive...@gmail.com> 于2024年1月26日周五 17:50写道： > > +1 (binding) > > - Verified checksums and signatures > - Passed all the HerdDB tests (https://github.com/diennea/herddb/pull/819) > - Built locally on Mac, JDK11 > > Thanks > Enrico > > Il giorno ven 19 gen 2024 alle ore 03:08 Hang Chen > <chenh...@apache.org> ha scritto: > > > > Hi everyone, > > Please review and vote on the release candidate #0 for version 4.16.4, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed > > to dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "v4.16.4-rc0" [4] with git sha [5] > > > > BookKeeper's KEYS file contains the PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review the maven repo, release tag, licenses, and any other things > > you think it is important to release. > > > > The vote will be open for at least 72 hours. It is adopted by the > > majority approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Release Manager > > > > [1] https://github.com/apache/bookkeeper/pull/4182/files > > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.16.4-rc0/ > > [3] > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1091 > > [4] https://github.com/apache/bookkeeper/tree/v4.16.4-rc0 > > [5] 16de712d8c8f1f0296697331bb68c1ad0eb5787d
