Yesterday, I manually triggered CI for branch/4.16, but it failed. I think the root reason is gRPC's version is not compatible with netty. And branch/4.16's gRPC contains several CVEs. I think we need to discuss whether to update the gRPC version in branch/4.16
``` [INFO] Running org.apache.bookkeeper.metadata.etcd.EtcdLayoutManagerTest Error: Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.862 s <<< FAILURE! -- in org.apache.bookkeeper.metadata.etcd.EtcdLayoutManagerTest Error: org.apache.bookkeeper.metadata.etcd.EtcdLayoutManagerTest.testReadCreateDeleteLayout -- Time elapsed: 0.016 s <<< ERROR! java.io.IOException: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNKNOWN at org.apache.bookkeeper.metadata.etcd.EtcdUtils.lambda$ioResult$0(EtcdUtils.java:150) at org.apache.bookkeeper.common.concurrent.FutureUtils.result(FutureUtils.java:89) at org.apache.bookkeeper.metadata.etcd.EtcdUtils.ioResult(EtcdUtils.java:146) at org.apache.bookkeeper.metadata.etcd.EtcdLayoutManager.readLedgerLayout(EtcdLayoutManager.java:62) at org.apache.bookkeeper.metadata.etcd.EtcdLayoutManagerTest.testReadCreateDeleteLayout(EtcdLayoutManagerTest.java:58) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNKNOWN at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:592) at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:551) at io.etcd.jetcd.ClientConnectionManager.lambda$null$3(ClientConnectionManager.java:287) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ... 1 more Caused by: io.grpc.StatusRuntimeException: UNKNOWN at io.grpc.Status.asRuntimeException(Status.java:539) at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:544) at io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39) at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23) at io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40) at io.etcd.jetcd.auth.AuthInterceptor$1$1.onClose(AuthInterceptor.java:101) at io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:489) at io.grpc.internal.DelayedClientCall$DelayedListener.delayOrExecute(DelayedClientCall.java:453) at io.grpc.internal.DelayedClientCall$DelayedListener.onClose(DelayedClientCall.java:486) at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:576) at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:70) at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:757) at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:736) at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133) ... 3 more Caused by: java.lang.UnsupportedOperationException at io.grpc.netty.AbstractHttp2Headers.iterator(AbstractHttp2Headers.java:500) at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:425) at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:352) at io.netty.handler.codec.http2.Http2InboundFrameLogger$1.onHeadersRead(Http2InboundFrameLogger.java:56) at io.netty.handler.codec.http2.DefaultHttp2FrameReader$2.processFragment(DefaultHttp2FrameReader.java:477) at io.netty.handler.codec.http2.DefaultHttp2FrameReader.readHeadersFrame(DefaultHttp2FrameReader.java:485) at io.netty.handler.codec.http2.DefaultHttp2FrameReader.processPayloadState(DefaultHttp2FrameReader.java:249) at io.netty.handler.codec.http2.DefaultHttp2FrameReader.readFrame(DefaultHttp2FrameReader.java:166) at io.netty.handler.codec.http2.Http2InboundFrameLogger.readFrame(Http2InboundFrameLogger.java:41) at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder.decodeFrame(DefaultHttp2ConnectionDecoder.java:188) at io.netty.handler.codec.http2.Http2ConnectionHandler$FrameDecoder.decode(Http2ConnectionHandler.java:393) at io.netty.handler.codec.http2.Http2ConnectionHandler.decode(Http2ConnectionHandler.java:453) at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:530) at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:469) at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:801) at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ... 1 more ``` Thanks ZhangJian He Twitter: shoothzj Wechat: shoothzj On Tue, May 28, 2024 at 4:09 PM Enrico Olivelli <eolive...@gmail.com> wrote: > Il Mar 28 Mag 2024, 09:18 ZhangJian He <shoot...@gmail.com> ha scritto: > > > Thank you for your trust. I think we are closer, there are PRs need to be > > handle before release > > > > https://github.com/apache/bookkeeper/pull/4398 BTW, Can we use one pr to > > include 3 cherry-pick PRs? There are both vertx,netty dependency > updates. > > Is this valid? > > https://github.com/apache/bookkeeper/pull/4400 > > https://github.com/apache/bookkeeper/pull/4395 > > > Yes you can but please not squash them > > Enrico > > > > > > > Thanks > > ZhangJian He > > Twitter: shoothzj > > Wechat: shoothzj > > > > > > On Mon, May 27, 2024 at 2:57 PM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > +1 thanks > > > > > > Enrico > > > > > > Il Lun 27 Mag 2024, 08:52 Nicolò Boschi <boschi1...@gmail.com> ha > > scritto: > > > > > > > +1 > > > > There are important bug fixes to release > > > > > > > > Thanks for taking care of the release > > > > Nicolò Boschi > > > > > > > > Il giorno sab 25 mag 2024 alle ore 04:37 ZhangJian He > > > > <shoot...@gmail.com> ha scritto: > > > > > > > > > > Hi all, > > > > > > > > > > BookKeeper 4.16.5 was released one and half months ago, and I would > > > > > like to discuss the starting 4.16.6 release to include some > critical > > > > > security and bug fixes. > > > > > > > > > > Here are the PRs for 4.16.6: > > > > > PR-4.16.6 > > > > > < > > > > > > > > > > https://github.com/apache/bookkeeper/pulls?q=is%3Apr+label%3Arelease%2F4.16.6+is%3Amerged > > > > > > > > > > > > > > > There are still some PRs not been cherry-picked due to conflict, I > > will > > > > > handle them these days. I removed open PRs that were targeting > > > > > 4.16.6 label. > > > > > > > > > > If you have other PRs that you want to be included in this release, > > > > please > > > > > tag the PR with the "release/4.16.6" and let me know in this > thread. > > > > > > > > > > If there's any concern, I'd like to volunteer to guide this > release. > > > > > > > > > > Thanks > > > > > ZhangJian He > > > > > Twitter: shoothzj > > > > > Wechat: shoothzj > > > > > > > > > >
