+1 On Thu, Apr 17, 2025 at 8:27 PM Enrico Olivelli <eolive...@gmail.com> wrote:
> +1 > > Thanks > > Enrico > > Il Gio 17 Apr 2025, 10:22 Lari Hotari <lhot...@apache.org> ha scritto: > > > Hello BookKeeper community, > > > > I'd like to propose upgrading our RocksDB dependency from the current > > 7.10.2 version to 9.9.3. > > Among all 9.x versions, I specifically chose 9.9.3 since it's > > currently the most recent version with multiple patch releases and > > it's readily available in Maven Central [1]. > > > > Upgrading RocksDB would bring important benefits: > > - Bug fixes and improvements made in RocksDB since 7.10.2 > > - Multiple bug fixes specifically related to CompactRange [2,3] > > > > RocksDB 9.x uses format_version=6 by default, which isn't backward > > compatible with RocksDB versions before 8.6.0. > > We've addressed this in our codebase by: > > 1. Explicitly setting format_version=5 in configuration files for all > > RocksDB database instances > > 2. Fixing several bugs where format_version wasn't set consistently > > across all database instances (PRs #4466, #4480, #4559, and #4560) > > With these changes, we've verified that upgrade/downgrade > > compatibility tests pass successfully. > > > > The PR to upgrade to 9.9.3 is > > https://github.com/apache/bookkeeper/pull/4580 > > > > If there are no significant objections, I suggest that we target this > > upgrade for the 4.18.0 release. > > > > Looking forward to your feedback! > > > > Best regards, > > > > -Lari > > > > 1 - https://search.maven.org/artifact/org.rocksdb/rocksdbjni > > 2 - > > > https://github.com/facebook/rocksdb/releases?q=CompactRange&expanded=true > > 3 - https://github.com/facebook/rocksdb/blob/main/HISTORY.md > > >
