GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1082
Jclouds machines: do not persist NodeMetadata or Template
Work in progress:
* requires the same to be done for `JcloudsWinrmMachineLocation`
* requires more testing for backwards compatibility (see the unit test
included here; but needs tested in the wild).
Previously JcloudsSshMachineLocation would persist the `NodeMetadata` and
the `Template`, which pulled in lots of jclouds stuff. This was very brittle:
if the NodeMetadata fields changed, or something like
`AzureComputeTemplateOptions` fields changed, then rebind could fail.
This changes `JcloudsSshMachineLocation` to not persist node and template.
Instead it persists the nodeId + imageId + privateAddresses + publicAddresses +
hostname (i.e. the things in NodeMetadata that are most important).
For backwards compatibility, if on rebind it finds the node in the
persisted state then it extracts the fields we need, sets those, and then sets
the `node` field to null. Same for the `template` field.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
jclouds-do-not-persist-NodeMetadata
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1082
----
commit 353920b76b28511f5c91ea4256e7b369063bf33b
Author: Aled Sage <[email protected]>
Date: 2015-10-21T19:41:50Z
jclouds machine: donât persist node+template
commit 999f6140dfb7da3f6ab8df8f4cdb84a4b83f1bc2
Author: Aled Sage <[email protected]>
Date: 2015-12-02T16:33:58Z
Fix SshMachineLocation.getSshHostAndPort
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
