Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1093#discussion_r47369700
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalLocationManager.java
---
@@ -78,9 +85,13 @@
public LocalLocationManager(LocalManagementContext managementContext) {
this.managementContext = checkNotNull(managementContext,
"managementContext");
this.locationFactory = new
InternalLocationFactory(managementContext);
-
+
this.storage = managementContext.getStorage();
- locationTypes = storage.getMap("locations");
+ this.locationTypes = storage.getMap("locations");
+
+ BasicExecutionManager executionManager = new
BasicExecutionManager(managementContext.getManagementNodeId());
--- End diff --
Do we really need to create our own `BasicExecutionManager`? Can we not
reuse `managementContext.getExecutionManager()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
