Github user Graeme-Miller commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1107#discussion_r47521109
  
    --- Diff: docs/guide/yaml/example_yaml/brooklyn-elk-catalog.bom ---
    @@ -9,27 +9,28 @@ brooklyn.catalog:
         name: ELK Stack
         id: ELK-Stack
         description: |
    -      Simple ELK stack deployment: it installs ES, Kibana and lostash as a 
child of Apache Tomcat 8
    +      Simple ELK stack deployment: provisions Elasticsearch, Kibana and 
Logtash as a child of Apache Tomcat 8
         services:
           - type: elasticsearch
             id: es
    -        name:  es
    +        name:  Elasticsearch Cluster
             brooklyn.config:
               install.version: 1.4.4
           - type: kibana-standalone
             id: kibana
    -        name: kibana
    +        name: Kibana Server
             customize.latch: 
$brooklyn:component("es").attributeWhenReady("service.isUp")
             brooklyn.config:
               kibana.elasticsearch.ip: 
$brooklyn:component("es").attributeWhenReady("host.address.first")
               kibana.elasticsearch.port: 
$brooklyn:component("es").config("elasticsearch.http.port")
           - type: org.apache.brooklyn.entity.webapp.tomcat.Tomcat8Server
    -        id: jboss
    +        id: tomcat
    +        war: 
https://tomcat.apache.org/tomcat-8.0-doc/appdev/sample/sample.war
    --- End diff --
    
    best to leave out the war as it creates a dependency of that URL. The 
example works without it (you can access the tomcat admin UI).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to