Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1112#issuecomment-165432762
nice work. one substantive comment -- if not addressing, put a TODO in the
doc. but for instance i could see it useful to set an entity etc. also
pathological case but if user wanted to say
external_prefix=$brooklyn:external
this would break it. if we supported `literal` we could say:
external_prefix=$brooklyn:literal("$brooklyn:external")
also docs need update:
* to say what is permitted in properties (ie currently only
`$brooklyn:external(...)`)
* to say that the method for constructing `BrooklynProperties` has changed
(release notes / api breakages)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
