Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1157#issuecomment-172668296
Looks good. I confirmed that the example still works at
https://brooklyn.apache.org/v/latest/start/blueprints.html (which uses the
script at https://bit.ly/brooklyn-visitors-creation-script).
@ygy @grkvlt do we also want to include `NO_ENGINE_SUBSTITUTION`, which
according to http://dev.mysql.com/doc/refman/5.6/en/sql-mode.html is the
default in MySQL 5.6.6 and later? Looking at the default file in
`mysql-5.6.26-osx10.9-x86_64/my.cnf`, it has
`sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES`. I think we produced the
templated version of the configuration file before those options were added to
the defaults.
Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
